Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "For perf, use the new ConstructorInvoker APIs for ActivatorUtilities.CreateFactory" #89992

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Revert "For perf, use the new ConstructorInvoker APIs for ActivatorUtilities.CreateFactory" #89992

merged 1 commit into from
Aug 4, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 4, 2023

Reverts #89573

@ghost ghost assigned jkotas Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #89573

Author: jkotas
Assignees: jkotas
Labels:

area-Extensions-DependencyInjection
Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Aug 4, 2023

#89573 (comment)

@AaronRobinsonMSFT
Copy link
Member

Failure appears to be known. Merging due to the breaking change impact.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit ba196ce into main Aug 4, 2023
100 of 103 checks passed
@stephentoub stephentoub mentioned this pull request Aug 4, 2023
Open
@stephentoub stephentoub deleted the revert-89573-DiPerf branch August 4, 2023 13:17
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@buyaa-n buyaa-n buyaa-n approved these changes

@steveharter steveharter Awaiting requested review from steveharter

Assignees

@jkotas jkotas

Labels
area-Extensions-DependencyInjection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @AaronRobinsonMSFT @buyaa-n