Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate running PAL tests out to their own jobs/steps. #91643

Merged
merged 18 commits into from
Sep 8, 2023

Conversation

jkoritzinsky
Copy link
Member

This helps us separate the different test legs in our product that are different. Instead of including the PAL tests in the cross-job copying and the significant logic around generating work items for the src/tests test tree in Helix, create a simple dedicated job for building and running the PAL tests on each platform.

eng/pipelines/runtime.yml Outdated Show resolved Hide resolved
@jkoritzinsky jkoritzinsky marked this pull request as ready for review September 7, 2023 22:54
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I'd feel more confident if someone more knowledgeble in the CI yml scripts took a look too.

@jkoritzinsky jkoritzinsky requested a review from a team September 7, 2023 23:16
@jkoritzinsky
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks Jeremy!

@trylek
Copy link
Member

trylek commented Sep 8, 2023

Having said that, I see that helixpublishwitharcade.proj still refers to PreparePALTestArchive at line 135, I would guess that's why multiple legs of your PR failed, that will need addressing.

@jkoritzinsky
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

The new jobs all passed, so merging this in.

@jkoritzinsky jkoritzinsky merged commit ab5a75e into dotnet:main Sep 8, 2023
226 of 236 checks passed
@jkoritzinsky jkoritzinsky deleted the paltests-separate-job branch September 8, 2023 17:27
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants