-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append job attempt number to log artifact names #91658
Conversation
Avoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsAvoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we tried that once in the past but for some reason had to revert. But if it works, great.
@ViktorHofer yes it seems to work. looking at the artifacts UI I wonder though whether moving the attempt as a prefix looks better, i.e. this instead of this or maybe even dropping the what do you think? |
Can we skip the attempt part for the first run and only add it for attempt number >= 2?
AttemptX as a prefix looks better IMO. |
I thought about that but the only way I can see it working is defining a separate variable in
Changed to prefix. |
Avoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.