Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append job attempt number to log artifact names #91658

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

akoeplinger
Copy link
Member

Avoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.

Avoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.
@ghost
Copy link

ghost commented Sep 6, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Avoids errors like "Artifact Installer-Logs-coreclr--windows_arm64-Debug already exists for build 1636423." when retrying jobs.

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we tried that once in the past but for some reason had to revert. But if it works, great.

@akoeplinger
Copy link
Member Author

akoeplinger commented Sep 6, 2023

@ViktorHofer yes it seems to work. looking at the artifacts UI I wonder though whether moving the attempt as a prefix looks better, i.e. this

image

instead of this

image

or maybe even dropping the Attempt and just use the number, e.g. BuildLogs_1_CoreCLR_freebsd_x64_release?

what do you think?

@ViktorHofer
Copy link
Member

Can we skip the attempt part for the first run and only add it for attempt number >= 2?

wonder though whether moving the attempt as a prefix looks better, i.e. this

AttemptX as a prefix looks better IMO.

@akoeplinger
Copy link
Member Author

Can we skip the attempt part for the first run and only add it for attempt number >= 2?

I thought about that but the only way I can see it working is defining a separate variable in eng/pipelines/common/variables.yml but I think we hit issues in the past with not every pipeline/template importing that one. Besides that it'd probably be confusing because it'd sort the second-attempt-logs below the first-attempt ones.

AttemptX as a prefix looks better IMO.

Changed to prefix.

@akoeplinger akoeplinger merged commit 25414bb into dotnet:main Sep 7, 2023
166 of 172 checks passed
@akoeplinger akoeplinger deleted the append-attempt branch September 7, 2023 14:02
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants