NativeAOT runtime PAL cleanup #91831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkotas
commented
Sep 9, 2023
jkotas
commented
- Enable printing of assert messages on Unix and delete NO_UI_ASSERT define
- Delete MessageBox-based assert dialog. We have dropped it on CoreCLR some time ago too
- Simplify implementation of PalVirtualAlloc to just what is needed
- Add missing implementation of PalVirtualFree
- Delete a few other unused methods
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
|
jkotas
force-pushed
the
asserts
branch
2 times, most recently
from
8853257
to
89a3736
Compare
- Enable printing of assert messages on Unix and delete NO_UI_ASSERT define - Delete MessageBox-based assert dialog. We have dropped it on CoreCLR some time ago too - Simplify implementation of PalVirtualAlloc to just what is needed - Add missing implementation of PalVirtualFree - Delete a few other unused methods
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 10, 2023
MichalStrehovsky
approved these changes
Sep 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.