Implement support for InlineArray in the trimmer
#92060
Conversation
Types annotated with `InlineArray` need to preserve all of their fields, even if otherwise this would not be the case. It's possible to have a struct with `LayoutKind.Auto` and with `InlineArray` - trimmer would normally trim fields on such struct. This leads to corruption since the field is never accessed directly. This changes the marking to preserve all fields on a type with `InlineArray` attribute just like we would for explicit layout struct and similar other types. Adds tests to cover both the explicit usage of `InlineArray` attribute as well as the compiler generate usage via collection literals.
vitek-karas
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsTypes annotated with This changes the marking to preserve all fields on a type with Adds tests to cover both the explicit usage of This should resolve the trimming part of #92022
|
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/InlineArrayDataflow.cs
Outdated
Show resolved
Hide resolved
…rrayDataflow.cs Co-authored-by: Sven Boemer <sbomer@gmail.com>
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6195934219 |
ghost
locked as resolved and limited conversation to collaborators
Types annotated with
InlineArrayneed to preserve all of their fields, even if otherwise this would not be the case. It's possible to have a struct withLayoutKind.Autoand withInlineArray- trimmer would normally trim fields on such struct. This leads to corruption since the field is never accessed directly.This changes the marking to preserve all fields on a type with
InlineArrayattribute just like we would for explicit layout struct and similar other types.Adds tests to cover both the explicit usage of
InlineArrayattribute as well as the compiler generate usage via collection literals.This should resolve the trimming part of #92022
And it also adds tests for #88684