Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][AOT] Space in path to published project on unix #94306

Merged
merged 4 commits into from
Dec 5, 2023
Merged

[browser][AOT] Space in path to published project on unix #94306

merged 4 commits into from
Dec 5, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Nov 2, 2023 •
edited
Loading

Fixed by dotnet/emsdk#611.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Nov 2, 2023
@ilonatommy ilonatommy self-assigned this Nov 2, 2023
@ghost
Copy link

ghost commented Nov 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Theoretically, enclosing included directories in quotations should be enough to escape spaces in Unix.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Build-mono
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Nov 2, 2023
Closed
@ilonatommy
Copy link
Member Author

Converting to draft till dotnet/emsdk#611 gets propagated to runtime repo.

@ilonatommy ilonatommy marked this pull request as draft November 22, 2023 11:50
@akoeplinger
Copy link
Member

dotnet/emsdk#611 is in runtime main now

@ilonatommy ilonatommy marked this pull request as ready for review December 5, 2023 16:48
radical
radical approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! 🎊 Assuming the tests pass, LGTM 👍 Thank you!

@ilonatommy ilonatommy merged commit 185a22a into dotnet:main Dec 5, 2023
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @akoeplinger @radical