Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the concept of packable fields from EEClass #96699

Commits on Jan 9, 2024

  1. Remove the concept of packable fields from EEClass

    - EEClass has long had a concept of packable rarely accessed fields
    - When we had NGEN we had logic to make these fields take very small amounts of space, but now that we no longer have NGEN, this code is not actually used in practice
    - The unpacked form of these fields used 4 bytes per field, even though many of them were logically 2 byte fields
    - The NumBoxed fields were just unnecessary, especially if we have a HasBoxedThreadStatics flag, which this change adds
    - Move the HasBoxed flags to the WFLAGS_LOW_ENUM
    
    Overall this saves 24 bytes per EEClass and moves all these fields onto a normal structure.
    davidwrighton committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    8ae6508 View commit details
    Browse the repository at this point in the history
  2. Update src/coreclr/vm/array.cpp

    Co-authored-by: Austin Wise <AustinWise@gmail.com>
    davidwrighton and AustinWise committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    c34201c View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Merge branch 'main' of github.com:dotnet/runtime into remove_special_…

    …ngen_thing_for_EEClass_fields
    davidwrighton committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a87b1d7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'remove_special_ngen_thing_for_EEClass_fields' of github…

    ….com:davidwrighton/runtime into remove_special_ngen_thing_for_EEClass_fields
    davidwrighton committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1576fa1 View commit details
    Browse the repository at this point in the history
  3. Quick fix

    davidwrighton committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    966c47b View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    86979ce View commit details
    Browse the repository at this point in the history