Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vectorized implementations of Log to Vector64/128/256/512 #96913

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

tannergooding
Copy link
Member

This makes progress towards #93513

@ghost
Copy link

ghost commented Jan 12, 2024

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes progress towards #93513

Author: tannergooding
Assignees: tannergooding
Labels:

area-System.Numerics

Milestone: -

@tannergooding
Copy link
Member Author

CC. @stephentoub, @michaelgsharp for review.

Will likely put up separate PRs for a few others over the weekend, like Exp and the rest of the ones already accelerated for float in TensorPrimitives

May also finish up several of the trig ones (Cos, Sin, Tan, etc)

@stephentoub
Copy link
Member

I assume structurally this is a carbon-copy of #93513?

@tannergooding
Copy link
Member Author

I assume structurally this is a carbon-copy of #93513?

Yes, same general setup/considerations. Just for the Log method now instead of Log2

@tannergooding
Copy link
Member Author

Test failures are known and tracked.

@tannergooding tannergooding merged commit 06005da into dotnet:main Jan 17, 2024
174 of 178 checks passed
@tannergooding tannergooding deleted the fix-93513 branch January 17, 2024 16:53
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
…net#96913)

* Adding vectorized implementations of Log to Vector64/128/256/512

* Accelerate TensorPrimitives.Log for double

* Ensure the ref assembly is updated to include the new Log method

* Fix the variance for one of the Log2 tests to account for the scalar fallback
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants