Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more ServicePoint properties #97537

Merged
merged 41 commits into from
Mar 1, 2024

Conversation

liveans
Copy link
Member

@liveans liveans commented Jan 26, 2024

This PR implements:
HttpWebRequest:

  • DefaultMaximumErrorResponseLength

ServicePoint:

  • BindIPEndPointDelegate
  • ProtocolVersion
  • UseNagleAlgorithm
  • Certificate

ServicePoint but no effect (We're creating a new handler for every request if we have non-null ServicePoint):
These properties will matter in case we want to invest some work in caching of HttpClient under HttpWebRequest, the current implementation is straightforward and these properties are not gaining any advantage from it.

  • ConnectionLimit
  • MaxIdleTime
  • ConnectionLeaseTimeout

@ghost
Copy link

ghost commented Jan 26, 2024

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: liveans
Assignees: liveans
Labels:

area-System.Net

Milestone: -

@liveans
Copy link
Member Author

liveans commented Jan 26, 2024

Maybe I can implement the IdleSince property from ServicePoint by using PlaintextStreamFilter.

PlaintextStreamFilter = (context, ct) =>
{
    ServicePoint.IdleSince = DateTime.Now;

    return ValueTask.FromResult(context.PlaintextStream);
}

But not sure if this is a good idea, any suggestions @dotnet/ncl ?

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple questions + style changes, otherwise this looks good

@liveans
Copy link
Member Author

liveans commented Feb 28, 2024

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Feb 28, 2024

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@liveans
Copy link
Member Author

liveans commented Mar 1, 2024

/azp run runtime-libraries-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liveans
Copy link
Member Author

liveans commented Mar 1, 2024

CI failures unrelated

@liveans liveans merged commit 4a89242 into dotnet:main Mar 1, 2024
109 of 119 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants