Fix some generic math DIMs to have the correct behavior #98510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis resolves #98285
|
tannergooding
commented
Feb 15, 2024
| @@ -37,7 +37,7 @@ static virtual TSelf LeadingZeroCount(TSelf value) | |||
| return TSelf.CreateChecked(bitCount); | |||
| } | |||
|
|
|||
| return (bitCount - TSelf.One) ^ TSelf.Log2(value); | |||
| return TSelf.IsNegative(value) ? TSelf.Zero : ((bitCount - TSelf.One) ^ TSelf.Log2(value)); | |||
There was a problem hiding this comment.
Log2 throws for negative integer values, so we need to explicitly check "is negative"
tannergooding
commented
Feb 15, 2024
Comment on lines
+168
to
+171
| if (TSelf.IsNaN(value)) | ||
| { | ||
| ThrowHelper.ThrowArithmeticException(SR.Arithmetic_NaN); | ||
| } |
There was a problem hiding this comment.
Sign is supposed to throw for NaN (unlike CopySign which does not). It's a historical behavior/contract of the API.
This was referenced Feb 16, 2024
This was referenced Feb 16, 2024
skyoxZ
reviewed
Feb 17, 2024
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Numerics/DimTests.GenericMath.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 18, 2024
|
Rerunning CI before merge. |
This was referenced Mar 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #98285