[LoongArch64] Fix some errors of the struct argument parsing in LoongArch64PassStructInRegister.cs #98744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @shushanhf , @jkotas |
am11
added
arch-loongarch64
community-contribution
jkotas
reviewed
Feb 21, 2024
| } | ||
|
|
||
| Debug.Assert(fieldIndex < numIntroducedFields); | ||
| Debug.Assert(fieldIndex <= numIntroducedFields); |
There was a problem hiding this comment.
Whan can fieldIndex == numIntroducedFields?
There was a problem hiding this comment.
fieldIndex may be equal to numIntroducedFields before the condition if (field.IsStatic);
But it can't be equal here. Thank you very much, I will amend it.
jkotas
reviewed
Feb 21, 2024
| { | ||
| continue; | ||
| return (uint)StructFloatFieldInfoFlags.STRUCT_NO_FLOAT_FIELD; |
There was a problem hiding this comment.
Should this case be rather handled in the default: case of the switch statement below?
There was a problem hiding this comment.
I will amend this, thank you!
…Arch64PassStructInRegister.cs
LuckyXu-HF
force-pushed
the
main-LA64-3
branch
from
7be578b
to
6cbbf1d
Compare
|
hi @jkotas ,Could you please review this PR again ? Thank you very much. |
jkotas
approved these changes
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the issue #69705 to amend the LA's port.
Fix some errors of the struct argument parsing in LoongArch64PassStructInRegister.cs