[browser] WS cancelation fix #99522
Merged
[browser] WS cancelation fix #99522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
ilonatommy
reviewed
Mar 11, 2024
| @@ -135,9 +135,10 @@ private WebSocketState FastState | |||
|
|
|||
| internal Task ConnectAsync(Uri uri, List<string>? requestedSubProtocols, CancellationToken cancellationToken) | |||
| { | |||
| AbortIfCancelationRequested(cancellationToken); | |||
There was a problem hiding this comment.
Why moving it out of the lock?
There was a problem hiding this comment.
It probably doesn't matter
| { | ||
| Abort(); | ||
| } // lock | ||
| cancellationToken.ThrowIfCancellationRequested(); |
There was a problem hiding this comment.
fyi: this internally checks for 'cancellationToken.IsCancellationRequested`.
...System.Net.WebSockets.Client/src/System/Net/WebSockets/BrowserWebSockets/BrowserWebSocket.cs
Outdated
Show resolved
Hide resolved
…ockets/BrowserWebSockets/BrowserWebSocket.cs Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
ilonatommy
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98201
Fixes #98145