Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Updated MsQuic version #99681

Merged
merged 3 commits into from
Mar 14, 2024
Merged

[QUIC] Updated MsQuic version #99681

merged 3 commits into from
Mar 14, 2024

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP requested a review from rzikm March 13, 2024 12:29
carlossanlop
carlossanlop approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@ManickaP ManickaP merged commit 09db2b5 into dotnet:main Mar 14, 2024
3 checks passed
@ManickaP ManickaP deleted the msquic-version branch March 14, 2024 11:11
@EgorBo
Copy link
Member

EgorBo commented Mar 14, 2024

Hm.. local build fails for me with this:

  Restored C:\prj\runtime\src\tasks\MonoTargetsTasks\MonoTargetsTasks.csproj (in 1.52 sec).
C:\prj\runtime\src\libraries\System.Net.Quic\src\System.Net.Quic.csproj : error NU1604: Warning As Error: Project depen
dency Microsoft.Native.Quic.MsQuic.Schannel does not contain an inclusive lower bound. Include a lower bound in the dep
endency version to ensure consistent restore results. [C:\prj\runtime\Build.proj]
  Failed to restore C:\prj\runtime\src\libraries\System.Net.Quic\src\System.Net.Quic.csproj (in 2.83 sec).

@jakobbotsch
Copy link
Member

I see the same. Bad interaction between this and #99713?

@CarnaViire
Copy link
Member

CarnaViire commented Mar 14, 2024 •
edited
Loading

cc @carlossanlop @ViktorHofer fyi

@ManickaP
Copy link
Member Author

I'm working on a fix.

@ManickaP
Copy link
Member Author

Fix in #99756

@CarnaViire
Copy link
Member

@EgorBo @jakobbotsch fix merged

This was referenced Mar 14, 2024
Open
Closed
@MichalPetryka MichalPetryka mentioned this pull request Mar 14, 2024
Merged
@karelz karelz added this to the 9.0.0 milestone Mar 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@CarnaViire CarnaViire CarnaViire approved these changes

@rzikm rzikm Awaiting requested review from rzikm

Assignees

@ManickaP ManickaP

Labels
area-System.Net.Quic
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ManickaP @EgorBo @jakobbotsch @CarnaViire @carlossanlop @karelz @lewing