Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the CryptoKit interop entrypoints to use the Swift calling convention #99970

Merged
merged 7 commits into from
Mar 22, 2024

Conversation

jkoritzinsky
Copy link
Member

This does not change the APIs yet, as we need Swift struct lowering support in Mono before we can switch to using more structured Swift types.

This PR switches the entry-points on the C side to use non-method symbols as we'll lose the ability to represent the Swift signatures well in C as we move to a more Swift-friendly API surface (until we are able to remove the native PAL API surface)

…vention

This does not change the APIs yet, as we need Swift struct lowering support in Mono before we can switch to using more structured Swift types.

This PR switches the entry-points on the C side to use non-method symbols as we'll lose the ability to represent the Swift signatures well in C as we move to a more Swift-friendly API surface (until we are able to remove the native PAL API surface)
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

…ress-of operation explicit in the DllImportEntry macro.
…ll is added to Mono) instead of using DllImportEntry, which now takes an address
Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
@jkoritzinsky
Copy link
Member Author

/ba-g The unrecognized failure is #99142, which was closed as a fix was made after this PR started running CI

@jkoritzinsky jkoritzinsky merged commit af6a9f3 into dotnet:main Mar 22, 2024
157 of 163 checks passed
@jkoritzinsky jkoritzinsky deleted the simple-swift-cryptokit branch March 22, 2024 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants