Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix over-warning bug when specifying runtime CLI option on dotnet run #21561

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Fix over-warning bug when specifying runtime CLI option on dotnet run #21561

merged 2 commits into from
Oct 1, 2021

Conversation

sfoslund
Copy link
Member

Fixes #21560

@sfoslund
Copy link
Member Author

@marcpopMSFT We're in M2 mode starting at 4, right? When does M2 mode end?

dsplaisted
dsplaisted approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue wasn't so much that it was warning, but that the --self-contained parameter wasn't supported at all by dotnet run?

@sfoslund
Copy link
Member Author

So the issue wasn't so much that it was warning, but that the --self-contained parameter wasn't supported at all by dotnet run?

Yep, at least not explicitly.

@marcpopMSFT
Copy link
Member

M2 mode ends Friday at 4pm

@sfoslund
Copy link
Member Author

sfoslund commented Oct 1, 2021

Approved by Don

@sfoslund sfoslund merged commit 3374353 into dotnet:release/6.0.1xx-rc2 Oct 1, 2021
@sfoslund sfoslund deleted the FixRuntimeCliWarning branch October 1, 2021 15:41
@sfoslund sfoslund mentioned this pull request Oct 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@joeloff joeloff joeloff approved these changes

Assignees
No one assigned
Labels
Area-CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfoslund @marcpopMSFT @dsplaisted @joeloff