Improve loading of Roslyn assemblies on validate package task (#22277) #24339
Conversation
…#22277) * Improve loading of Roslyn assemblies on validate package task * PR Feedback
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| @@ -6,7 +6,7 @@ | |||
| <IsPackable>true</IsPackable> | |||
| <IsShippingPackage>true</IsShippingPackage> | |||
| <StrongNameKeyId>Open</StrongNameKeyId> | |||
| <VersionPrefix>1.0.0</VersionPrefix> | |||
| <VersionPrefix>1.1.0</VersionPrefix> | |||
There was a problem hiding this comment.
Separately we were discussing just calculating this based on the repo branding, is that possible? Maybe we can address the stabilization issue in this PR too.
There was a problem hiding this comment.
We could do that, but I thought that we said we were going to do that on main. The only problem about doing that here, is that main today generates builds that are 2.0.0 so making that change here will start generating versions that are greater (in NuGet's comparisons) to main branch. If that's ok with you, I'd rather make that version change first in main branch, and then cherry pick back if we think it is necessary.
I'm not on the .NET source-build team anymore: +cc @dotnet/source-build-internal |
Contributes to #22353
Porting #22277 to release/6.0
cc: @carlossanlop @ericstj @dagood
After this change is in and we have a build for it, I will go ahead and create a PR in runtime to update the version of PackageValidation we use.