Update the sdk build to target net8.0

[marcpopMSFT]

No description provided.

[marcpopMSFT]

@dougbu do you happen to know how to avoid the aspnet analyzer exceptions? This is our first try to move the sdk to targeting 8.0 and using the 8.0 sdk.
CSC : error AD0001: Analyzer 'Microsoft.AspNetCore.Analyzers.Http.RequestDelegateReturnTypeAnalyzer' threw an exception of type 'System.NullReferenceException' with message 'Object reference not set to an instance of an object.'. [D:\a\1\s\src\Tests\Microsoft.AspNetCore.Watch.BrowserRefresh.Tests\Microsoft.AspNetCore.Watch.BrowserRefresh.Tests.csproj]
##[error]CSC(0,0): error AD0001: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer 'Microsoft.AspNetCore.Analyzers.Http.RequestDelegateReturnTypeAnalyzer' threw an exception of type 'System.NullReferenceException' with message 'Object reference not set to an instance of an object.'.

[dougbu]

@marcpopMSFT I think @JamesNK and @captainsafia are our HTTP analyzer specialists. See a few commits from @halter73 too. Hope one of them can help you.

[JamesNK]

I’ll take a look.

[JamesNK]

I've identified the problem. The fix is in aspnetcore so you'll need to wait for the update to flow through.

[marcpopMSFT]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[marcpopMSFT]

@JamesNK the SDK main branch is on aspnetcore 8.0.0-alpha.1.22517.3 and I tried rerunning this PR but it still failed with the same error. What else needs to be done to unblock this?

[JamesNK]

When I ran build on main I got 8.0.0-alpha.1.22512.9 of the SDK restored. Its commit was from before my changes - dotnet/aspnetcore@361e628

[JamesNK]

When I ran build on main I got 8.0.0-alpha.1.22512.9 of the SDK restored. Its commit was from before my changes - dotnet/aspnetcore@361e628

You're still using the same SDK without the fix...

Do you need to update the SDK in this PR's global.json to get a newer version with the fixed analyzer?

[nagilson]

Seems this is still looking for net7.0:

    C:\h\w\B756097F\p\ex\msbuildExtensions\Microsoft\Microsoft.NET.Build.Extensions\Microsoft.NET.Build.Extensions.NETFramework.targets(114,5): error MSB4062: The "AddFacadesToReferences" task could not be loaded from the assembly 

C:\h\w\B756097F\p\ex\msbuildExtensions\Microsoft\Microsoft.NET.Build.Extensions\\tools\net7.0\Microsoft.NET.Build.Extensions.Tasks.dll.
 Could not load file or assembly 'C:\h\w\B756097F\p\ex\msbuildExtensions\Microsoft\Microsoft.NET.Build.Extensions\tools\net7.0\Microsoft.NET.Build.Extensions.Tasks.dll'. 
 The system cannot find the path specified. Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\B756097F\t\dotnetSdkTests\r1lisw1i.eln\Anet462Projec---F15591BC\TestApp\TestApp.csproj]

[marcpopMSFT]

@lewing GetPackDefinitionLocations is failing because it sees Microsoft.NETCore.App.Runtime.osx-arm64 and osx.x64 in both the 8 and 7 manifests from what I can tell. CC @dsplaisted

[nagilson]

@dotnet/aspnet-blazor-eng Looks like a lot of the remaining failures (or all) are tests in blazor-wasm. Do these need to be updated to allow targeting 8.0? May you please take a look? cc @marcpopMSFT

[marcpopMSFT]

Latest change is getting closer.

@dotnet/aspnet-blazor-eng can you take a look at the blazor failures that all appear to be similar to this:
Expected File C:\h\w\9FDD0948\t\dotnetSdkTests\ep3bpqss.izk\Pack_Multiple---7F5CE8C3\bin\Debug\net8.0\PackageLibraryTransitiveDependency.dll to exist, but it does not.

@dotnet/templating-engine-maintainers there are a few template engine tests also failing. Can you take a look as well?

[marcpopMSFT]

@dotnet/aspnet-blazor-eng can you take a look at the blazor failures that all appear to be similar to this: Expected File C:\h\w\9FDD0948\t\dotnetSdkTests\ep3bpqss.izk\Pack_Multiple---7F5CE8C3\bin\Debug\net8.0\PackageLibraryTransitiveDependency.dll to exist, but it does not.
The tests that are still failing are compiling for net7.0. I don't think the default TFM can be switched though as other tests will fail. Not sure if the set that are failing should be modified now to target net7.0 explicitly.

[RussKie]

We updating this in many places, is it worth changing to this?

Suggested change

	<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net8.0</_BlazorWebAssemblySdkTasksTFM>
	<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">$(SdkTargetFramework)</_BlazorWebAssemblySdkTasksTFM>

[dreddy-work]

@dotnet/aspnet-blazor-eng , can anyone take a look here? both WinForms and WPF are blocked from flowing up.

[vlada-shubina]

Latest change is getting closer.

@dotnet/aspnet-blazor-eng can you take a look at the blazor failures that all appear to be similar to this: Expected File C:\h\w\9FDD0948\t\dotnetSdkTests\ep3bpqss.izk\Pack_Multiple---7F5CE8C3\bin\Debug\net8.0\PackageLibraryTransitiveDependency.dll to exist, but it does not.

@dotnet/templating-engine-maintainers there are a few template engine tests also failing. Can you take a look as well?

templating tests were fixed in 4da0821

[nagilson]

@dotnet/aspnet-blazor-eng PTAL, there are at least 10+ PRs blocked by this I can think of now

[javiercn]

@nagilson we have PRs out to address this across all the branches, but the one on main is blocked on some other dotnet-watch tests failing. See:
#29093

These other PRs are just waiting on confirmation that we can merge on the target branches
#29118
#29119
#29120

[marcpopMSFT]

@tmat I believe Noah said that you were already looking into dotnet watch failures. Looks like there are four failures now here in those tests.

[dreddy-work]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kasperk81]

framework error There is not enough space on the disk. is unrelated.

merge?

[nagilson]

Merge. 😏