"Publish" our tasks assembly into platform-specific folders inside our NuGet package. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r NuGet package. This allows us to put platform-specific dependencies in the NuGet package, and fixes the issue of getting FileNotFound 'System.Security.Cryptography.Algorithms' on net46 by adding that assembly to our NuGet package. Along with this change, I refactored the nuspec to include all files under the "PackagesLayout" folder, which means we no longer have to duplicate each file. "Build" just needs to place the file in the correct spot under "PackagesLayout". Fix #45
Merged
|
A bit hard to follow the flow of all the files, but if it builds and everything is in the right place, then 👍 :) |
|
|
||
| <!-- Add our tasks assembly --> | ||
| <CopyLocalAssembly Include="$(AssemblyName)$(TargetExt)"> | ||
| <FullFilePath>$(OutDir)\$(AssemblyName)$(TargetExt)</FullFilePath> |
There was a problem hiding this comment.
Could you use TargetPath here?
There was a problem hiding this comment.
Good call. I could have if I continued this same approach. But in my latest commit, I moved all this logic out of this project and into the NuGet project.
Also use a Regex to match DestinationTFM properties in CopyLocalAssembly to know which TFM directory to copy assemblies to.
nguerrera
pushed a commit
that referenced
this pull request
Oct 10, 2016
"Publish" our tasks assembly into platform-specific folders inside our NuGet package.
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
Fixing the task to use the right name based on MSBuildRuntimeType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to put platform-specific dependencies in the NuGet package, and fixes the issue of getting FileNotFound 'System.Security.Cryptography.Algorithms' on net46 by adding that assembly to our NuGet package.
Along with this change, I refactored the nuspec to include all files under the "PackagesLayout" folder, which means we no longer have to duplicate each file. "Build" just needs to place the file in the correct spot under "PackagesLayout".
Fix #45
@brthor @livarcocc @piotrpMSFT @natidea
/cc @ericstj @dotnet/project-system