change Microsoft.NET.Test.Sdk version from 17.3.2 to 17.4.0 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would upgrade the templates for 8.0 as well, but not the earlier ones. |
sure will do that |
|
@Sapana-Khemkar who do we need to review this? @nohwnd ? |
I am on it :)
We usually update all because the insertion is blocked on dotnet/installer side. Truethly speaking, I think it would be better to update only new templates as it makes it hard to look at this repo and understand why versions don't match local but that's discussion for another PR. |
Evangelink
reviewed
Feb 9, 2023
|
we will close this one because we're changing the templating strategy. We will open a new one asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #277
Support for ppc64le processor architecture has been added in VSTest repo here which is part of release 17.4.0.
Hence on ppc64le, we have to use Microsoft.NET.Test.Sdk version 17.4.0 in templates.
Note:
I have changed version in 7.0 template only as ppc64le is supported from .NET7 only. Not sure if we want to upgrade version for all versions.