Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#279, #295 仍有问题,重构 #306

Merged
merged 2 commits into from
May 23, 2023
Merged

#279, #295 仍有问题,重构 #306

merged 2 commits into from
May 23, 2023

Conversation

PurplestViper
Copy link
Contributor

  • AspectExceptionWrapper 改为瞬态,因 AspectActivatorFactory 是单例,跟随注入的 AspectExceptionWrapper 将提升为单例,潜在并发问题依然存在。现不再使用 AspectExceptionWrapper,直接在 AspectActivator 中使用 ExceptionDispatchInfo
  • AspectInvocationException 被用来包装自身异常无意义,因为直接实例化的 innerException 不包含堆栈信息,会对外部调用者造成信息干扰,现创建 AspectInvalidCastExceptionAspectInvalidOperationException 以抛出现有自身异常,与外部异常进行区分。
  • 增加复制自 ThrowExceptionTesterThrowExceptionDirectlyTester 测试,以测试 ThrowAspectException=false 时是否能够抛出原始异常。

@liuhaoyang liuhaoyang merged commit cddd616 into dotnetcore:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants