Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone serialize deadcode #17

Merged
merged 2 commits into from
May 5, 2024

Refactor: Adding Serialize and Clone. Removed deadcode warning

7a75187
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Clone serialize deadcode #17

Refactor: Adding Serialize and Clone. Removed deadcode warning
7a75187
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded May 5, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (4)

src/paged_client.rs|63 col 11| warning: trait AsyncIteratorAsyncNext is never used
--> src/paged_client.rs:63:11
|
63 | pub trait AsyncIteratorAsyncNext {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(dead_code)] on by default
Cargo.toml|28 col 11| error: lint group nursery has the same priority (0) as a lint
--> Cargo.toml:28:1
|
28 | nursery = "deny"
| ^^^^^^^ ------ has an implicit priority of 0
29 | unwrap_used = "deny"
| ----------- has the same priority as this lint
|
= note: the order of the lints in the table is ignored by Cargo
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
= note: #[deny(clippy::lint_groups_priority)] on by default
help: to have lints override the group set nursery to a lower priority
|
28 | nursery = { level = "deny", priority = -1 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Cargo.toml|27 col 12| error: lint group pedantic has the same priority (0) as a lint
--> Cargo.toml:27:1
|
27 | pedantic = "deny"
| ^^^^^^^^ ------ has an implicit priority of 0
28 | nursery = "deny"
29 | unwrap_used = "deny"
| ----------- has the same priority as this lint
|
= note: the order of the lints in the table is ignored by Cargo
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set pedantic to a lower priority
|
27 | pedantic = { level = "deny", priority = -1 }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/paged_client.rs|94 col 15| warning: assigning the result of Clone::clone() may be inefficient
--> src/paged_client.rs:94:15
|
94 | self.after = Option::clone(&va.paging.after);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use clone_from(): Clone::clone_from(&mut self.after, &va.paging.after)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: #[warn(clippy::assigning_clones)] on by default