Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: interface query on m-m joins and select specific columns #1398

Merged
merged 28 commits into from
Jul 2, 2020
Merged

refactor: interface query on m-m joins and select specific columns #1398

merged 28 commits into from
Jul 2, 2020

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jun 15, 2020 •
edited
Loading

Refactor Flask-AppBuilder SQLAlchemy Interface query

@dpgaspar dpgaspar marked this pull request as ready for review June 15, 2020 15:43
@dpgaspar
add tests with many children
65d1759
@dpgaspar
a bit of refactor on the refactor
c3e772e
@dpgaspar
remove prints
a119c81
@dpgaspar
Merge branch 'master' into refactor/interface-query
cfb5d89
@dpgaspar
fix and cleanup
ddcd26b
@dpgaspar
Merge remote-tracking branch 'origin/refactor/interface-query' into r…
7d93f71 
…efactor/interface-query
@dpgaspar
fix and cleanup
020b8e3
@dpgaspar
type annotations and code quality
f340c8a
@dpgaspar
type annotations and code quality
8c34130
@dpgaspar
type annotations and code quality
1c5ab9f
@dpgaspar
lint
47424d0
@dpgaspar
more type annotations
108146a
@dpgaspar
only use from_self if necessary
db2127d
@dpgaspar
Merge branch 'master' into refactor/interface-query
4f01462
@dpgaspar
fix column model query loading for non inner queries
b5bba74
@dpgaspar
Merge remote-tracking branch 'origin/refactor/interface-query' into r…
46ca15f 
…efactor/interface-query
@dpgaspar
Drying and fix get with improved performance
f1041fe
@dpgaspar
MVC starts using select columns, maybe revert
1085568
@dpgaspar
revert select_columns from mvc
00f4e5d
@dpgaspar
feat: list_select_columns to enable wider config
7cd065f
@dpgaspar
one or none instead of first
a570de6
@dpgaspar
doc show_select_columns and list_select_columns
deecae8
@dpgaspar
fix, one or none instead of first
ecd5bfb
@dpgaspar
Merge branch 'master' into refactor/interface-query
e00451e
@dpgaspar
fix, docs
9036f65
@dpgaspar
Merge remote-tracking branch 'origin/refactor/interface-query' into r…
dd189a9 
…efactor/interface-query
@dpgaspar dpgaspar merged commit c5ca06b into master Jul 2, 2020
@dpgaspar dpgaspar deleted the refactor/interface-query branch July 2, 2020 18:35
This was referenced Jul 3, 2020
Merged
Merged
ashb added a commit to ashb/Flask-AppBuilder that referenced this pull request Oct 22, 2020
@ashb
Fix "actions" on ModelViews with composite primary keys
414adeb 
The refactor in dpgaspar#1398 changes the `get()` function, and mistakenly
always applied the PK filter, even in the case of composite keys.

(The else block of `if self.is_pk_composite` applied it again, so it was
actually applying the same filter twice, which didn't break anything,
but was not needed)
@ashb ashb mentioned this pull request Oct 22, 2020
Merged
6 tasks
ashb added a commit to ashb/Flask-AppBuilder that referenced this pull request Oct 22, 2020