-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCWEB-8414 번들러 Webpack, Rollup 제거와 vite마이그레이션 #90
Changes from all commits
5843db3
b34b789
f67fc23
e7bbf69
f4a4230
bca3fce
7c6db3e
748f722
3456913
2b128fc
6cf3ba2
b2ce8f7
209483b
060798c
20918e3
16d8e69
be6e694
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
.github | ||
.eslintrc.js | ||
vite.config.ts | ||
dist | ||
docs | ||
public |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
const path = require('path'); | ||
|
||
module.exports = { | ||
extends: ['react-app', 'airbnb-typescript', 'airbnb/hooks', 'prettier'], | ||
parserOptions: { | ||
project: './tsconfig.json', | ||
}, | ||
rules: { | ||
// react | ||
'react/jsx-filename-extension': 0, | ||
'react/prop-types': 0, | ||
'react/jsx-one-expression-per-line': 0, | ||
'react/destructuring-assignment': 0, | ||
'react/no-unused-state': 0, | ||
'react/jsx-props-no-spreading': 0, | ||
'react/jsx-curly-newline': 0, | ||
'react/jsx-wrap-multilines': 0, | ||
'react/require-default-props': 0, | ||
'react/no-unescaped-entities': 0, | ||
'react/forbid-prop-types': 0, | ||
'react/jsx-uses-react': 'off', | ||
'react/react-in-jsx-scope': 'off', | ||
// 웹 접근성 | ||
'jsx-a11y/click-events-have-key-events': 0, | ||
'jsx-a11y/no-static-element-interactions': 0, | ||
'jsx-a11y/no-noninteractive-element-interactions': 0, | ||
'jsx-a11y/no-autofocus': 0, | ||
'jsx-a11y/mouse-events-have-key-events': 0, | ||
'jsx-a11y/label-has-associated-control': 0, | ||
'jsx-a11y/media-has-caption': 0, | ||
// Javascript | ||
'arrow-body-style': ['error', 'as-needed'], | ||
'consistent-return': 0, | ||
'no-underscore-dangle': 0, | ||
'no-unused-expressions': 0, | ||
'no-async-promise-executor': 0, | ||
'no-restricted-syntax': 0, | ||
'no-await-in-loop': 0, | ||
'prefer-destructuring': ['error', { object: true, array: false }], | ||
// Module | ||
'import/no-extraneous-dependencies': 0, | ||
'import/prefer-default-export': 0, | ||
'import/order': [ | ||
'error', | ||
{ | ||
groups: [ | ||
['builtin', 'external'], | ||
['internal', 'parent', 'sibling'], | ||
], | ||
pathGroups: [ | ||
{ | ||
pattern: 'global-style/**', | ||
group: 'sibling', | ||
position: 'after', | ||
}, | ||
{ | ||
pattern: './*.constant', | ||
group: 'sibling', | ||
position: 'after', | ||
}, | ||
{ | ||
pattern: './*.text', | ||
group: 'sibling', | ||
position: 'after', | ||
}, | ||
{ | ||
pattern: './*.styles', | ||
group: 'sibling', | ||
position: 'after', | ||
}, | ||
{ | ||
pattern: './*.scss', | ||
group: 'sibling', | ||
position: 'after', | ||
}, | ||
{ | ||
pattern: './*.css', | ||
group: 'sibling', | ||
position: 'after', | ||
}, | ||
{ | ||
pattern: 'assets/**', | ||
group: 'sibling', | ||
position: 'after', | ||
}, | ||
], | ||
'newlines-between': 'always', | ||
}, | ||
], | ||
// typescript eslint | ||
'@typescript-eslint/no-unused-expressions': 0, | ||
'@typescript-eslint/naming-convention': [ | ||
'error', | ||
{ | ||
selector: 'variable', | ||
format: ['camelCase', 'UPPER_CASE', 'PascalCase'], | ||
leadingUnderscore: 'allow', | ||
}, | ||
], | ||
'@typescript-eslint/no-use-before-define': 'off', | ||
}, | ||
env: { | ||
browser: true, | ||
}, | ||
settings: { | ||
'import/resolver': { | ||
node: { | ||
paths: [path.resolve(__dirname, 'src')], | ||
extensions: ['.js', '.jsx', '.ts', '.tsx', '.json'], | ||
}, | ||
}, | ||
}, | ||
ignorePatterns: ['vite.config.ts'], | ||
}; |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: Workflows on PR | ||
|
||
on: | ||
pull_request: | ||
types: [opened, reopened, ready_for_review] | ||
|
||
jobs: | ||
run-linter: | ||
uses: dramancompany/shared_workflows/.github/workflows/linter.yml@main | ||
with: | ||
nodeVersion: 16 | ||
autoFix: true | ||
useRememberUI: false | ||
secrets: inherit | ||
|
||
assign-reviewers: | ||
if: ${{ (contains(github.event.pull_request.base.ref, 'main') || contains(github.event.pull_request.base.ref, 'feature')) && (github.event.action == 'opened' || github.event.action == 'reopened' || github.event.action == 'ready_for_review') }} | ||
uses: dramancompany/shared_workflows/.github/workflows/assign-reviewers.yml@main |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
12.14.1 | ||
16.17.0 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
.github | ||
vite.config.ts | ||
dist | ||
docs | ||
public |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,8 @@ export const parameters = { | |
|
||
/** | ||
* global decorators | ||
* @see https://vitejs.dev/guide/features.html#jsx | ||
* vite 설정으로 인해 JSX syntax를 사용하려면 .jsx 확장자를 사용해야한다. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 제목이 곧 내용 |
||
*/ | ||
export const decorators = [ | ||
(Story) => ( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
MIT License | ||
|
||
Copyright (c) 2022 Drama&Company | ||
|
||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
|
||
The above copyright notice and this permission notice shall be included in all | ||
copies or substantial portions of the Software. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
SOFTWARE. |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
타입스크립트 경로 매핑을 위해 vite-tsconfig-paths를 사용하여 tsconfig.json에 설정되어있는 세팅을 가져다 사용하고 있습니다.
storybook은 자동으로 root경로에 있는 컴파일러 설정을 가져올 수 없고 위와같이 설정을 덮어 씌워줘야 정상적으로 작동합니다