Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regression of v0.9.0 #62

Merged
merged 4 commits into from
Dec 13, 2017
Merged

fix regression of v0.9.0 #62

merged 4 commits into from
Dec 13, 2017

Conversation

masakij
Copy link
Contributor

@masakij masakij commented Dec 12, 2017

This PR fixes following problems. ⬇️

  • mouse cursor style with readonly
    • now: pointer
    • expected: auto
  • unit test failed because of missing createRenderer
  • unable to access webpack-dev-server from remote

@dreyescat dreyescat merged commit 00beceb into dreyescat:master Dec 13, 2017
@dreyescat
Copy link
Owner

Thanks for your contribution! You fixed issu #59 too 👍

Regarding accessing webpack-dev-server from remote... It should work because --host 0.0.0.0 binds to the all zero IP. If I am not wrong it worked before. Bear in mind the this project is already using the deprecated version 1 of webpack. Maybe an upgrade to v2 is required.

@dreyescat
Copy link
Owner

Released version v0.9.1

@masakij
Copy link
Contributor Author

masakij commented Dec 13, 2017

Thanks for accepting my PR! 👍

Regarding accessing webpack-dev-server from remote...

I got a Error (Invalid Host header ) when I accessed wevpack-dev-server from remote.
I found solution on this issue (webpack/webpack-dev-server#882 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masakij @dreyescat