Skip to content

Commit

Permalink
Fix write_chunked_header to support zero chunk length
Browse files Browse the repository at this point in the history
  • Loading branch information
rmja authored and bugadani committed May 21, 2024
1 parent 3c6cd6f commit a813563
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion src/body_writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ const fn get_max_chunk_header_size(buffer_size: usize) -> usize {
fn write_chunked_header(buf: &mut [u8], chunk_len: usize) -> usize {
let mut hex = [0; 2 * size_of::<usize>()];
hex::encode_to_slice(chunk_len.to_be_bytes(), &mut hex).unwrap();
let leading_zeros = hex.iter().position(|x| *x != b'0').unwrap_or_default();
let leading_zeros = hex.iter().position(|x| *x != b'0').unwrap_or(hex.len() - 1);
let hex_chars = hex.len() - leading_zeros;
buf[..hex_chars].copy_from_slice(&hex[leading_zeros..]);
buf[hex_chars..hex_chars + NEWLINE.len()].copy_from_slice(NEWLINE);
Expand Down Expand Up @@ -289,6 +289,23 @@ mod tests {
assert_eq!(4, get_max_chunk_header_size(0x12 + 2 + 2));
}

#[test]
fn can_write_chunked_header() {
let mut buf = [0; 4];

let len = write_chunked_header(&mut buf, 0x00);
assert_eq!(b"0\r\n", &buf[..len]);

let len = write_chunked_header(&mut buf, 0x01);
assert_eq!(b"1\r\n", &buf[..len]);

let len = write_chunked_header(&mut buf, 0x0F);
assert_eq!(b"f\r\n", &buf[..len]);

let len = write_chunked_header(&mut buf, 0x10);
assert_eq!(b"10\r\n", &buf[..len]);
}

#[tokio::test]
async fn preserves_already_written_bytes_in_the_buffer_without_any_chunks() {
// Given
Expand Down

0 comments on commit a813563

Please sign in to comment.