Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(hacky) update embedded-io to 0.5 #40

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

kbleeke
Copy link
Contributor

@kbleeke kbleeke commented Sep 30, 2023

I realize there is already discussion and plans to address this in #39 but I had the urge to update my hobby embassy project now: ;)

I'm still posting it, in case someone finds it useful

I mostly propagate WriteAllError or collapse it down to embedded_io::ErrorKind when that's not an option.

@kbleeke kbleeke changed the title update embedded-io to 0.5 (hacky) update embedded-io to 0.5 Sep 30, 2023
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thanks for doing the effort. I think we should just merge this for now, even if it's as you say a little hacky. The alternative is not being useable with later embassy versions for some time.

@rmja @bugadani Wdyt?

@bugadani
Copy link
Contributor

bugadani commented Sep 30, 2023

No objections, there's very little point in waiting for future changes to happen. We will be able to revert this in whole or in parts if the WriteAllError stuff gets removed. Worst case, the 0.7 version of reqwless will be short lived and very specific in what portion of the embedded ecosystem it works with.

@kbleeke kbleeke marked this pull request as ready for review September 30, 2023 11:31
@lulf lulf merged commit 8872395 into drogue-iot:main Sep 30, 2023
1 check passed
@lulf
Copy link
Member

lulf commented Sep 30, 2023

Released as 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants