Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kotlin optional in OSGI Import-Package statement #473

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Make Kotlin optional in OSGI Import-Package statement #473

merged 1 commit into from
Oct 14, 2022

Conversation

essobedo
Copy link
Contributor

Motivation

For now, even if we don't need Kotlin, we have to add it as dependency when using dropbox-sdk-java in an OSGI bundle.

Modifications:

  • Define all kotlin packages as optional

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2022

CLA assistant check
All committers have signed the CLA.

@essobedo
Copy link
Contributor Author

Related to apache/camel-karaf#199

@greg-db
Copy link
Contributor

greg-db commented Oct 14, 2022

Thanks! I'll ask the team to review this.

@devPalacio
Copy link
Contributor

Thanks for your contribution! We'll release an updated version with this change shortly.

@devPalacio devPalacio merged commit 7fd13fc into dropbox:main Oct 14, 2022
@essobedo essobedo deleted the make-kotlin-optional branch October 14, 2022 14:40
@handstandsam
Copy link
Contributor

Thanks, the Kotlin Dependency is compileOnly as it's only used in the Android related code.

@handstandsam
Copy link
Contributor

We are in the process of publishing, when it's up, you'll be able to see it at https://repo1.maven.org/maven2/com/dropbox/core/dropbox-core-sdk/5.4.3/

Anywhere from 30 mins to 4 hours (depends on how maven central is doing today)

@essobedo
Copy link
Contributor Author

Thanks, the Kotlin Dependency is compileOnly as it's only used in the Android related code.

Yes, it is what I understood from the code, thanks for the clarifications

@handstandsam
Copy link
Contributor

Awesome. It is successfully published. I'll upload the javadocs, but you're good to go!

@essobedo
Copy link
Contributor Author

I've just upgraded to 5.4.3, it works well now thank you very much 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants