Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send token header when token is not set #24

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Don't send token header when token is not set #24

merged 1 commit into from
Jul 23, 2021

Conversation

sU8U7SfkcwTJVH7PjaVmej7D
Copy link
Contributor

@sU8U7SfkcwTJVH7PjaVmej7D sU8U7SfkcwTJVH7PjaVmej7D commented Jul 22, 2021 •
edited
Loading

Seems like github changed its policy: now, sending an empty token header results in a 403 error.
This commit fixes my CI.

dsaltares
dsaltares approved these changes Jul 22, 2021
View reviewed changes
Copy link
Owner

@dsaltares dsaltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsaltares
Copy link
Owner

@sU8U7SfkcwTJVH7PjaVmej7D (interesting handle) looks like the tests failed.

@sU8U7SfkcwTJVH7PjaVmej7D
Copy link
Contributor Author

sU8U7SfkcwTJVH7PjaVmej7D commented Jul 22, 2021 •
edited
Loading

@dsaltares:
INPUT_REPO=dsaltares/godot-wild-jam-18 INPUT_VERSION=tags/v0.1.18 INPUT_FILE=plague-linux.zip GITHUB_REPOSITORY=xxx INPUT_TOKEN= ./fetch_github_asset.sh works fine for me
INPUT_REPO=dsaltares/godot-wild-jam-18 INPUT_VERSION=tags/v0.1.18 INPUT_FILE=plague-linux.zip GITHUB_REPOSITORY=xxx INPUT_TOKEN=xxx ./fetch_github_asset.sh fails in the same way the CI test fails.

I guess the "***" in the CLI logs is a hidden token. Could you confirm the CI token used here is valid?

EDIT: I found an issue in the first call to curl and pushed an update. Could you run the CI tests again?

@dsaltares dsaltares merged commit cc2cafc into dsaltares:master Jul 23, 2021
BSteffaniak pushed a commit to FlatLang/fetch-airship that referenced this pull request Oct 12, 2022
@dsaltares
Merge pull request dsaltares#24 from sU8U7SfkcwTJVH7PjaVmej7D/master
2cbb6a5 
Don't send token header when token is not set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsaltares dsaltares dsaltares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sU8U7SfkcwTJVH7PjaVmej7D @dsaltares