Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing PHP Notice log noise #1

Closed
wants to merge 1 commit into from
Closed

fixing PHP Notice log noise #1

wants to merge 1 commit into from

Conversation

petermolnar
Copy link

I've added isset() before the !empty check because in case the $_POST value is unset, it may generate noise in log like:

PHP Notice:  Undefined index: geo_public in plugins/simple-location/loc-postmeta.php on line 173
PHP Notice:  Undefined index: geo_full in plugins/simple-location/loc-postmeta.php on line 179
PHP Notice:  Undefined index: geo_map in plugins/simple-location/loc-postmeta.php on line 184
PHP Notice:  Undefined index: geo_lookup in plugins/simple-location/loc-postmeta.php on line 221

I also replaced the 3x copy paste with a loop for the checkbox tests.

@dshanske dshanske closed this Oct 25, 2015
@dshanske
Copy link
Owner

Situation resolved

@timnolte timnolte mentioned this pull request Mar 27, 2018
Closed
@troutcolor troutcolor mentioned this pull request Mar 14, 2020
Closed
@dshanske dshanske mentioned this pull request Jul 12, 2020
Open
@thejeshgn thejeshgn mentioned this pull request Oct 13, 2020
Closed
This was referenced Nov 6, 2022
Closed
Closed
@asuh asuh mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petermolnar @dshanske