NPM and Grunt related changes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure, but I don't think these changes have anything to do with the failing CI tests. Do let me know if I need to change stuff to make them pass. |
|
Got confused between repos. Need to fix the devDependencies patch. |
This makes setting up easier. You can just run 'npm install' and then 'grunt'. We need to ignore the 'node_modules' directory as its managed by npm using the package.json file, no need for this to be checked in.
|
Fixed. |
|
I have some major changes in design in mind for this plugin |
|
That's great! I've been thinking of using this at a bunch of places myself. These changes are only build related and should be helpful in any case. |
Closed
This was referenced Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make setting up the project easier. Unfortunately https://github.com/wpreadme2markdown/wp-readme-to-markdown doesn't package for npm, and so we'll have to make that upstream change first.