Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error[E0635]: unknown feature proc_macro_span_shrink #398

Closed
cacilhas opened this issue Jul 3, 2023 · 2 comments
Closed

error[E0635]: unknown feature proc_macro_span_shrink #398

cacilhas opened this issue Jul 3, 2023 · 2 comments

Comments

@cacilhas
Copy link

cacilhas commented Jul 3, 2023 

error[E0635]: unknown feature `proc_macro_span_shrink`
  --> $HOME/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.59/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |

Stopped working in nightly 0.72.
@dtolnay
Copy link
Owner

dtolnay commented Jul 4, 2023

This was already fixed as of 4 weeks ago (1.0.60+).

@dtolnay dtolnay closed this as completed Jul 4, 2023
This was referenced Jul 5, 2023
Closed
Merged
@hexfusion hexfusion mentioned this issue Jul 12, 2023
Merged
@arpad-m arpad-m mentioned this issue Jul 13, 2023
Merged
5 tasks
arpad-m added a commit to neondatabase/neon that referenced this issue Jul 15, 2023
@arpad-m
Fix rustdoc warnings and test cargo doc in CI (#4711)
982fce1 
## Problem

`cargo +nightly doc` is giving a lot of warnings: broken links, naked
URLs, etc.

## Summary of changes

* update the `proc-macro2` dependency so that it can compile on latest
Rust nightly, see dtolnay/proc-macro2#391 and
dtolnay/proc-macro2#398
* allow the `private_intra_doc_links` lint, as linking to something
that's private is always more useful than just mentioning it without a
link: if the link breaks in the future, at least there is a warning due
to that. Also, one might enable
[`--document-private-items`](https://doc.rust-lang.org/cargo/commands/cargo-doc.html#documentation-options)
in the future and make these links work in general.
* fix all the remaining warnings given by `cargo +nightly doc`
* make it possible to run `cargo doc` on stable Rust by updating
`opentelemetry` and associated crates to version 0.19, pulling in a fix
that previously broke `cargo doc` on stable:
open-telemetry/opentelemetry-rust#904
* Add `cargo doc` to CI to ensure that it won't get broken in the
future.

Fixes #2557

## Future work
* Potentially, it might make sense, for development purposes, to publish
the generated rustdocs somewhere, like for example [how the rust
compiler does
it](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_driver/index.html).
I will file an issue for discussion.
@chorman0773
Copy link

chorman0773 commented Jul 25, 2023 •
edited
Loading

I had this break in a transitive dep (am not using the cfg). I hope that updating bytemuck, and thus bytemuck_derive deps on a fixed version of proc-macro2. It may be a good idea to look into how features in general are detected if it's using feature detection to avoid such breakage in the future (proper feature detection shouldn't have such a problem, but version comparisons can be broken by a rustc update).

@smoelius smoelius mentioned this issue Jul 28, 2023
Closed
black-puppydog added a commit to black-puppydog/solar that referenced this issue Aug 13, 2023
@black-puppydog
fix: use bleeding-edge version of proc-macro2
587c08b 
this is a transitive dependency that has recently been failing to compile.
See this issue:
dtolnay/proc-macro2#398
This was referenced Aug 27, 2023
Merged
Merged
@64kramsystem 64kramsystem mentioned this issue Sep 18, 2023
Closed
@lann lann mentioned this issue Sep 18, 2023
Closed
dennis-hamester added a commit to dennis-hamester/aldrin that referenced this issue Oct 13, 2023
@dennis-hamester
Bump proc-macro2 to 1.0.69 to fix a compilation regression
4a4f6e9 
See dtolnay/proc-macro2#398.
dennis-hamester added a commit to dennis-hamester/aldrin that referenced this issue Oct 13, 2023
@dennis-hamester
Bump proc-macro2 to 1.0.69 to fix a compilation regression
c710ded 
See dtolnay/proc-macro2#398.
Darksonn added a commit to tokio-rs/tokio that referenced this issue Oct 24, 2023
@Darksonn
Upgrade proc-macro2
b60b56e 
Refs: dtolnay/proc-macro2#398 (comment)
c19 added a commit to c19/clap that referenced this issue Nov 1, 2023
@c19
proc-macro2 bump to 1.0.69 to fix unknown feature proc_macro_span_shrink
8fa6816 
dtolnay/proc-macro2#398
@c19 c19 mentioned this issue Nov 1, 2023
Merged
@cdesch cdesch mentioned this issue Nov 15, 2023
Closed
Repository owner locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cacilhas @dtolnay @chorman0773