This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Export serde internal Serializer and Deserializer #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
changed the title
pickfire
commented
Apr 29, 2019
| type SerializeStructVariant = &'a mut Serializer<W>; | ||
|
|
||
| #[inline] | ||
| fn serialize_bool(self, value: bool) -> Result<()> { |
There was a problem hiding this comment.
@dtolnay I wonder if this is the correct method to do this or we should patch it to chyh1990/yaml-rust#127?
dtolnay
reviewed
Oct 4, 2019
There was a problem hiding this comment.
Closing because I don't think this is going to be the right approach. Per #44 (comment), I would prefer to switch away from yaml-rust as a yaml backend before attempting this change.
Thanks anyway!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #44.
SerializerSerializerwithWriterDeserializerDeserializerwithReaderBlocking on chyh1990/yaml-rust#127 and probably chyh1990/yaml-rust#33 as well.