This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Treat YAML 1.1 style octals with sign as string, not base 10 number #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd treat values like
0127
as correctly a string not a number, per the YAML 1.2 spec. However that check did not kick in when there was a sign:-0127
or+0127
, and those would end up getting parsed as a base 10 number via u64::from_str or i64::from_str, which is not correct.