Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing keys with values instead of values with keys? #33

Closed
dherman opened this issue Oct 1, 2019 · 2 comments
Closed

Replacing keys with values instead of values with keys? #33

dherman opened this issue Oct 1, 2019 · 2 comments

Comments

@dherman
Copy link
Contributor

dherman commented Oct 1, 2019

Am I reading the code wrong or did commits 59c0abf and 69a0d0d break normalization? The previous logic was replacing values with keys, but it looks like the updated logic replaces keys with values.
@dherman
Copy link
Contributor Author

dherman commented Oct 1, 2019

See https://github.com/dtolnay/trybuild/blob/master/src/normalize.rs#L137-L139

@dherman dherman mentioned this issue Oct 1, 2019
Merged
@dtolnay dtolnay mentioned this issue Oct 1, 2019
Closed
@dtolnay
Copy link
Owner

dtolnay commented Oct 1, 2019

Fixed in #32. I filed #34 to find a way to catch this kind of bug with tests.

@dtolnay dtolnay closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dherman @dtolnay