Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize separators in $WORKSPACE paths #32

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Normalize separators in $WORKSPACE paths #32

merged 2 commits into from
Oct 1, 2019

Conversation

dherman
Copy link
Contributor

@dherman dherman commented Oct 1, 2019

Fixes #30. All lines beginning with "::: " have their paths normalized to use Unix path separators, and the $WORKSPACE normalization takes this into account.

@dherman
Fixes #30. All lines beginning with "::: " have their paths normali…
9f31d86 
…zed to use Unix path separators, and the `$WORKSPACE` normalization takes this into account.
@dherman
Copy link
Contributor Author

dherman commented Oct 1, 2019

I'm probably confused but this maybe also fixes #33.

dherman added a commit to neon-bindings/neon that referenced this pull request Oct 1, 2019
@dherman
See if dtolnay/trybuild#32 fixes trybuild normalization for running t…
e542dda 
…he static tests in Windows.
@dherman dherman mentioned this pull request Oct 1, 2019
Merged
dtolnay
dtolnay approved these changes Oct 1, 2019
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You're not confused, I messed up #33 in a rush to get the workspace path available in the right place for your change. I filed #34 to track figuring out how trybuild should be tested to catch bugs like that.

@dtolnay dtolnay merged commit eaa9800 into dtolnay:master Oct 1, 2019
@dtolnay dtolnay mentioned this pull request Oct 1, 2019
Closed
@dtolnay
Copy link
Owner

dtolnay commented Oct 1, 2019

Published in 1.0.15.

@dherman dherman deleted the normalize-workspace-path-separators branch October 2, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize separators in $WORKSPACE paths
2 participants
@dherman @dtolnay