Fixed issues with minification

[ceterumnet]

There were a few places where the array syntax wasn't being used - this should fix those issues.

[andyperlitch]

@ceterumnet, I will check with @nickholub regarding minification, but I was under the impression that we will be using a module called ngmin which automatically makes angular code min-safe. If so, there's a chance we may not want to merge this request.

[ceterumnet]

@andyperlitch, there are several places in the code where you are already using the Array style syntax for DI - so it wouldn't be a huge stretch to be consistent with that :-)

Also, I'm not sure how that would work for folks like me where I like to include the non-minified source in my rails assets (makes it easy to use the javascript debugger), and then I use the asset pipeline to combine and minify all my javascripts. I don't know how unique I am in that regard.

Either way, this is a great project and I'll keep using / contributing.

Cheers,
Dave

[andyperlitch]

@ceterumnet fair enough, I would say that your use-case is not unique so it makes sense to do this. However, looking at your changes I see that you may have inadvertently changed the indent level in a few places from 2 to 4. Would you mind changing those back and I would be happy to merge!

[ceterumnet]

Ahh - I've fixed the whitespace issues. Sorry about that.

/d

[awashbrook]

Hi @nickholub and @andyperlitch, sorry things have been quiet over the last month. We are getting out dashboard production ready...nearly there!

Interested in whether you are still planning to adopt ngmin as ng-annote https://github.com/olov/ng-annotate appears to be the way forward, according to btford/ngmin#93?

[nickholub]

Great to hear, Andy! Currently we are using ng-min here https://github.com/DataTorrent/malhar-dashboard-webapp since it comes with Yeoman. We are totally open to improvements.