Refactor react-duckdb #1727
Open
Refactor react-duckdb #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been keeping an eye on these changes. It looks like they'll address some problems with race conditions in duckdb initialization. I've been holding off rewriting my connection management code because this refactor looks like a much cleaner implementation that's what's there. Thanks for your work @willium |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
react-duckdbproviders were pretty convoluted and had properties that it didn't use. I refactored it and added documentation and comments.I did not bump the version in
package.json. This is a breaking change for this package, so I suspect it should be (part of?) a major version bump.I may contribute some utility functions/additional hooks in the future, but these shouldn't cause breaking changes.