Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app does not compile on Xcode 16 beta #3298

Closed
iccub opened this issue Aug 31, 2024 · 0 comments · Fixed by #3299
Closed

The app does not compile on Xcode 16 beta #3298

iccub opened this issue Aug 31, 2024 · 0 comments · Fixed by #3299

Comments

@iccub
Copy link
Contributor

iccub commented Aug 31, 2024

Xcode 16 SDK introduced few changes that broke the app compilation for the DDG app.
While Xcode 15 can be still be used for development and distribution, Xcode 16 allows you to use newer Apple apis such as Translation services, Apple Intelligence frameworks, dark and light themed App icons.
IMO it's worth to prepare support for Xcode 16 ahead of iOS 18 release in September

Tested on Xcode 16.1 beta 16B5001e
Zrzut ekranu 2024-08-31 o 12 23 25
@iccub iccub mentioned this issue Aug 31, 2024
Merged
14 tasks
samsymons added a commit that referenced this issue Sep 9, 2024
@samsymons
Merge branch 'main' into sam/set-vpn-user-agent
a436229 
# By Christopher Brind (4) and others
# Via Alessandro Boron (1) and others
* main: (27 commits)
  Bump C-S-S to 6.14.1 (#3331)
  DuckPlayer Launch Experiment for iOS (#3328)
  defer loading the tab switcher button until view did load (#3326)
  Release 7.136.0-3 (#3324)
  Release PR: Check for the negative attribution case (#3311)
  fix tab switcher crashes (speculative fix) (#3319)
  Onboarding highlights feature flag setup (#3308)
  Release 7.136.0-2 (#3320)
  Attempt to fix dissapearing privacy icon (#3317)
  Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 (#3313)
  Bump BSK with C-S-S to 6.14.0 (#3314)
  ensure no atb or app version sent with pixel (#3315)
  Fix #3298: Add support for Xcode 16 (#3299)
  Fix Keychain Debug view controller segue (#3310)
  Release 7.136.0-1 (#3309)
  Fix an issue that causes the fire dialog to show multiple times for the same website after dismissing it (#3305)
  [DuckPlayer] 28. Open in Youtube -> Youtube App (#3290)
  usage segmentation (#3263)
  Fix wrong URL displayed for auth dialog (#3307)
  iOS Integration of BSK Onboarding (#3282)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3298: Add support for Xcode 16 iccub/ddg-iOS
1 participant
@iccub