Fix a bug in Gridster.add_faux_cell method #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line checks that the row doesn't already exist in the gridmap array; if it does then it doesn't need to be pushed to the faux_grid array. Otherwise, this function introduced a bug when I was dynamically adding widgets that had a row height > 1 as the first widget added. Any subsequent widget added would end up being at row 2 (rather than row 3, as the first widget already occupied the first 2 rows).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line checks that the row doesn't already exist in the gridmap array; if it does then it doesn't need to be pushed to the faux_grid array.
Otherwise, this function introduced a bug when I was dynamically adding widgets that had a row height > 1 as the first widget added. This function would overwrite it's second row entry with "false", making it seem that no element was in row 2, when actually there was. Any subsequent widget added would end up being at row 2 (rather than row 3, as the first widget already occupied the first 2 rows) because Gridster doesn't know that a widget was there.