Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xchange v2 ethereum trades #6727

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

mike-x7f
Copy link
Contributor

@mike-x7f mike-x7f commented Sep 17, 2024

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For adding to existing spell lineage

If you are adding to an existing spell lineage, please provide the following information:

  • Description: [Description of the changes made]

  • Add xchange_v2_ethereum_base_trades to dex/models/trades/ethereum schema file

  • Add xchange_v2_ethereum_base_trades to dex_ethereum_base_trades.sql

  • Add xchange_v2 XchangePair_evt_Swap and XchangeFactory_evt_PairCreated to Ethereum sources yml file

  • Add xchange_v2_ethereum_base_trades.sql leveraging xchange v2 factory pair created and swap data sources

  • Add xchange v2 transactions to seed file

Thank you for your contribution!

@dune-eng
Copy link

Workflow run id 10905320692 approved.

@dune-eng
Copy link

Workflow run id 10905320874 approved.

@jeff-dude jeff-dude added WIP work in progress dex labels Sep 18, 2024
@dune-eng
Copy link

Workflow run id 10952005502 approved.

@dune-eng
Copy link

Workflow run id 10952100182 approved.

@mike-x7f
Copy link
Contributor Author

@jeff-dude is this conflict causing the test to not run? I tried adding in the latest valantis ref statement, but that didn't seem to work. Is there something you can do to resolve the conflict so I can see if the tests pass this time? Thanks, Mike

@jeff-dude
Copy link
Member

@jeff-dude is this conflict causing the test to not run? I tried adding in the latest valantis ref statement, but that didn't seem to work. Is there something you can do to resolve the conflict so I can see if the tests pass this time? Thanks, Mike

yes, CI is blocked if there are merge conflicts into main branch. i was able to resolve on the PR page itself. can you confirm the modified files still look as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dex WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants