Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Sample people for testing groups on localhost #242

Closed
5 tasks done
nelsonic opened this issue Nov 4, 2022 · 3 comments
Closed
5 tasks done

Chore: Sample people for testing groups on localhost #242

nelsonic opened this issue Nov 4, 2022 · 3 comments
Assignees
@nelsonic
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Nov 4, 2022 •
edited
Loading

Context

At present when we are attempting to test adding people to a group we have nobody on our localhost ... 🤷‍♂️

Story

As an engineer building the groups feature,
I want to have some people in the DB on my localhost that I can use to test the autocomplete
So that I can confirm everything is working as expected

Todo

  • Source people profiles with:

    • givenName
    • email
    • picture

  • Create a seeds function to insert these people into the db when mix ecto.setup is run

This will mean sourcing a bunch of profiles e.g: https://github.com/dwyl/who
We can probably do this manually initially e.g. only need 5 people ...
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T1h Time Estimate 1 Hour chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Nov 4, 2022
@nelsonic nelsonic self-assigned this Nov 4, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Nov 4, 2022

https://auth.dwyl.com/people
dwyl-auth-people

Going to manually copy-paste these people details so that we can have some seed data in auth.

nelsonic added a commit that referenced this issue Nov 4, 2022
@nelsonic
add sample people for #242
179c833
@nelsonic
Copy link
Member Author

nelsonic commented Nov 4, 2022

Added 11 people: http://localhost:4000/people

image

This way we have some familiar faces we can test groups with. ✅

@nelsonic
Copy link
Member Author

nelsonic commented Nov 4, 2022

Please note: the sample data is being successfully inserted on localhost. ✅
The reason the CI is failing is that coverage is still below 100% ... 🙄

@nelsonic nelsonic closed this as completed Nov 4, 2022
@nelsonic nelsonic mentioned this issue Nov 4, 2022
Open
2 tasks
nelsonic added a commit that referenced this issue Dec 7, 2022
@nelsonic
add username field to all test records in lib/auth/init/people.ex #242
526ba9b
nelsonic added a commit that referenced this issue Dec 7, 2022
@nelsonic
update get_list_of_people/0 to include username #242
307c39d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic