Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logout Feature + Sessions #159

Merged
merged 59 commits into from
Nov 30, 2021
Merged

Add Logout Feature + Sessions #159

merged 59 commits into from
Nov 30, 2021

Commits on Nov 7, 2021

  1. add app_id, auth_provider and person_id (ref) to sessions table for #158 

     / rel: #30
    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    48166e7 View commit details
    Browse the repository at this point in the history

  2. update README.md badges (hits.com from hits.io)

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    35e5039 View commit details
    Browse the repository at this point in the history

  3. update deps

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    46a14d4 View commit details
    Browse the repository at this point in the history

  4. comment out lib/auth/mailer.ex as not used

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    86293d6 View commit details
    Browse the repository at this point in the history

  5. comment out Swoosh mailbox in lib/auth_web/router.ex as not used

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    f497f01 View commit details
    Browse the repository at this point in the history

  6. [WiP] enable sessions.ex for #30

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    f0b2125 View commit details
    Browse the repository at this point in the history

  7. create test/auth/session_test.exs with test for inserting session record

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    1f8ddf3 View commit details
    Browse the repository at this point in the history

  8. add Auth.Session.get/1 to retrieve session data from conn (with test)

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    e82f254 View commit details
    Browse the repository at this point in the history

  9. create Auth.Session.end_session/1 function for #30

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    9afe27c View commit details
    Browse the repository at this point in the history

  10. add @doc comments to new functions for sessions #30

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    ae0df5f View commit details
    Browse the repository at this point in the history

  11. create Auth.Session.start_session/1 helper function that returns conn… 

    … for pipelineing #30
    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    bd87f82 View commit details
    Browse the repository at this point in the history

  12. invoke Auth.Session.start_session/1 in redirect_or_render/3 for #30

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    0dbcdad View commit details
    Browse the repository at this point in the history

  13. Add tests and implementation of end_session/1

    @nelsonic
    nelsonic committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    5e76b7c View commit details
    Browse the repository at this point in the history

  14. add "async: true" to all tests saves 8 sec per run of suite. Thanks to … 

    …@plicjo for the reminder in https://youtu.be/jCtIDbU23lI
    @nelsonic
    nelsonic committed Nov 7, 2021
    1 Configuration menu
    Copy the full SHA
    46a33b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. add "mix ecto.setup" command to Procfile for heroku DB setup: #161 (c… 

    …omment)
    @nelsonic
    nelsonic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    504be23 View commit details
    Browse the repository at this point in the history

  2. use "mix ecto.migrate" command in Procfile for heroku DB setup: #161 … 

    …(comment)
    @nelsonic
    nelsonic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5050d8c View commit details
    Browse the repository at this point in the history

  3. update badge in README.md

    @nelsonic
    nelsonic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8f5cd14 View commit details
    Browse the repository at this point in the history

  4. implement GET /logout for sessions #30

    @nelsonic
    nelsonic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    d7ee22f View commit details
    Browse the repository at this point in the history

  5. add test for /logout endpoint #30

    @nelsonic
    nelsonic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    1ab51b9 View commit details
    Browse the repository at this point in the history

  6. add /api/logout (JSON) endpoint for #30

    @nelsonic
    nelsonic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    a875da1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. add app_id, auth_provider and person_id (ref) to sessions table for #158 

     / rel: #30
    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    cdca4b2 View commit details
    Browse the repository at this point in the history

  2. update README.md badges (hits.com from hits.io)

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    fb7ce2d View commit details
    Browse the repository at this point in the history

  3. update deps

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    cdd4d19 View commit details
    Browse the repository at this point in the history

  4. comment out lib/auth/mailer.ex as not used

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    ffaf768 View commit details
    Browse the repository at this point in the history

  5. comment out Swoosh mailbox in lib/auth_web/router.ex as not used

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    8713918 View commit details
    Browse the repository at this point in the history

  6. [WiP] enable sessions.ex for #30

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    3605620 View commit details
    Browse the repository at this point in the history

  7. create test/auth/session_test.exs with test for inserting session record

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    56c05bb View commit details
    Browse the repository at this point in the history

  8. add Auth.Session.get/1 to retrieve session data from conn (with test)

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    b675e3b View commit details
    Browse the repository at this point in the history

  9. create Auth.Session.end_session/1 function for #30

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    eed5281 View commit details
    Browse the repository at this point in the history

  10. add @doc comments to new functions for sessions #30

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    cb4a11a View commit details
    Browse the repository at this point in the history

  11. create Auth.Session.start_session/1 helper function that returns conn… 

    … for pipelineing #30
    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0ffcbae View commit details
    Browse the repository at this point in the history

  12. invoke Auth.Session.start_session/1 in redirect_or_render/3 for #30

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    227b9f0 View commit details
    Browse the repository at this point in the history

  13. Add tests and implementation of end_session/1

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    7499915 View commit details
    Browse the repository at this point in the history

  14. add "async: true" to all tests saves 8 sec per run of suite. Thanks to … 

    …@plicjo for the reminder in https://youtu.be/jCtIDbU23lI
    @nelsonic
    nelsonic committed Nov 22, 2021
    1 Configuration menu
    Copy the full SHA
    460f106 View commit details
    Browse the repository at this point in the history

  15. add "mix ecto.setup" command to Procfile for heroku DB setup: #161 (c… 

    …omment)
    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    58ef30f View commit details
    Browse the repository at this point in the history

  16. use "mix ecto.migrate" command in Procfile for heroku DB setup: #161 … 

    …(comment)
    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    1d8793c View commit details
    Browse the repository at this point in the history

  17. update badge in README.md

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    02780e4 View commit details
    Browse the repository at this point in the history

  18. implement GET /logout for sessions #30

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    6b5a2b3 View commit details
    Browse the repository at this point in the history

  19. add test for /logout endpoint #30

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0b21c1d View commit details
    Browse the repository at this point in the history

  20. add /api/logout (JSON) endpoint for #30

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0bfc555 View commit details
    Browse the repository at this point in the history

  21. [WiP] use auth_plug 1.4.1 for logout/1 #158

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    140bef4 View commit details
    Browse the repository at this point in the history

  22. fix merge conflicts

    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    2596cad View commit details
    Browse the repository at this point in the history

  23. temporarily comment out phoenix_live_dashboard as we are not yet usin… 

    …g it
    @nelsonic
    nelsonic committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    b5e4a1a View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. [WiP] update to auth_plug 1.4.3 with end_session/1 ... some tests fai… 

    …ling because of #163
    @nelsonic
    nelsonic committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    73b0403 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. fix failing test. but not yet "done" ...

    @nelsonic
    nelsonic committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    f5047b5 View commit details
    Browse the repository at this point in the history

  2. add test for failed attempt at GET /end_session for #158 / #30

    @nelsonic
    nelsonic committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a2cc4ab View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. use auth_plug 1.4.4 with updated end_session endpoint

    @nelsonic
    nelsonic committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    59af650 View commit details
    Browse the repository at this point in the history

  2. uses Session.get_by_id if there is a conn.assigns.sid #30

    @nelsonic
    nelsonic committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    b12b0ea View commit details
    Browse the repository at this point in the history

  3. avoid calling Auth.Session.end_session() in logout/2

    @nelsonic
    nelsonic committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    acddc23 View commit details
    Browse the repository at this point in the history

  4. use auth_plug 1.4.5 with end_session logging

    @nelsonic
    nelsonic committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    bc67bc9 View commit details
    Browse the repository at this point in the history

  5. use Map.get(conn.assigns, :person, ...

    @nelsonic
    nelsonic committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    266866c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. refactor session_end endpoint, handler and tests to accept the sessio… 

    …n_id for #158 / #30 see: #159 (comment)
    @nelsonic
    nelsonic committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    9e77fbb View commit details
    Browse the repository at this point in the history

  2. add Auth.Session.start_session/2 to test_helpers.exs for #158

    @nelsonic
    nelsonic committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    1b5f7a7 View commit details
    Browse the repository at this point in the history

  3. simplify update_session_end/1 as promised in #159 (comment)

    @nelsonic
    nelsonic committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    081bef1 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. tidy up end_session (comments) and logout/1 test

    @nelsonic
    nelsonic committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    71d2f10 View commit details
    Browse the repository at this point in the history

  2. Auth.Log.error when end_session client_id is invalid

    @nelsonic
    nelsonic committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    dcb6c2a View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. run mix deps.clean --unused --unlock to remove swoosh from mix.lock, #… 

    …159 (comment)
    @SimonLab
    SimonLab committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    17eb378 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. fix comment typo in lib/auth_web/controllers/api_controller.ex 

    Co-authored-by: Simon <simon.labondance@gmail.com>
    @nelsonic @SimonLab
    nelsonic and SimonLab committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    39567a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into logout-endpoint-issue-158

    @SimonLab
    SimonLab committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    cfad7f6 View commit details
    Browse the repository at this point in the history