Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select auth methods #185

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Select auth methods #185

wants to merge 4 commits into from

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Mar 9, 2022

ref: #183

@SimonLab SimonLab self-assigned this Mar 9, 2022
@SimonLab SimonLab temporarily deployed to dwylauth March 9, 2022 10:58 Inactive
@SimonLab
Copy link
Member Author

SimonLab commented Mar 9, 2022

Running mix ecto.reset and trying the run the application returns a constraint error:
image

Fixed by deleting ald session/cookies from the browser

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #185 (1fca726) into main (ec88a03) will not change coverage.
The diff coverage is n/a.

❗ Current head 1fca726 differs from pull request most recent head b71e141. Consider uploading reports for the commit b71e141 to get more accurate results

@@            Coverage Diff            @@
##              main      #185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          586       586           
=========================================
  Hits           586       586           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec88a03...b71e141. Read the comment docs.

@SimonLab SimonLab temporarily deployed to dwylauth March 16, 2022 10:42 Inactive
@SimonLab
Copy link
Member Author

SimonLab commented Mar 16, 2022

error while running mix ecto.reset:
image

It looks like the error is link when using Fields to insert the person email.

solution:

  • The application compiled however I forgot to source my environment variables
  • So Fields didn't have the right application configuration
  • delete deps rm -r deps/
  • run again mix ecto.reset which recompile the project and reinitialise the database
  • delete existing cookie on your browser and the application run correctly again

@nelsonic
Copy link
Member

Interesting ... LMK if you need help debugging. 🔍

@SimonLab
Copy link
Member Author

@nelsonic thanks, I just found out what was the issue, we just need to make sure the environment variables are sourced before the project is compiled! I've updated my previous comment with the solution

@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Jun 17, 2022
@nelsonic
Copy link
Member

nelsonic commented Jun 17, 2022

Hi @SimonLab, 👋
Keen to get at least the requirement captured by this PR. 📝
If we end up re-building auth using mix phx.gen.auth #207 ... 🤔
we want to have as many of the features/requirements captured as possible up-front. 💭
Please dedicate some time to this when you can. 🤞

P.S: obvs if you can get it working with tests, even better! 😜

@SimonLab SimonLab removed their assignment Jul 27, 2022
@SimonLab SimonLab removed the in-progress An issue or pull request that is being worked on by the assigned person label Jul 29, 2022
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished in-progress An issue or pull request that is being worked on by the assigned person technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Aug 26, 2022
@nelsonic
Copy link
Member

Let's re-visit this as part of the re-build #207 💭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants