PR: AUTH_API_KEY issue #42 #43
Conversation
nelsonic
added
the
in-progress
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 210 210
=========================================
Hits 210 210 Continue to review full report at Codecov.
|
| @@ -1,65 +0,0 @@ | |||
| exports.config = { | |||
There was a problem hiding this comment.
Brunch no longer used. #40
|
@SimonLab I have finished writing the tests (and code) for the Registration/Login with Email+Password feature #63 I'm not adding any more commits to this PR until you have completely reviewed it. Please review and share your thoughts when you can. (Monday at this stage). |
This comment has been minimized.
This comment has been minimized.
| |> Map.put(:username, profile.login) | ||
| |> Map.put(:givenName, profile.name) | ||
| |> Map.put(:picture, profile.avatar_url) | ||
| |> Map.put(:auth_provider, "github") |
There was a problem hiding this comment.
I think we might be able to use Map.merge here
There was a problem hiding this comment.
@SimonLab yes, definitely. 👍
This PR is quite epic.
It turned out to be a bit more code than I was expecting.
But I'm quite happy with the end result.
The code is definitely not perfect by any means.
But it has complete tests 💯 which means we can refactor if we need to!
The main thing is that it works.
So we can get back to building the features that people using our app actually care about!
What's included in this PR?
AUTH_API_KEYthey can use with the App EPIC: AUTH_API_KEY How to Run the App with a Single Environment Variable #42auth_client_idfrom URL to confirm request has validAUTH_API_KEYExtract client_id from HTTP referer #55 + Add auth_client_id to state in 3rd party auth urls #57upsert_person/1Upsert (Update or Insert) Person Record #53 when the profile of the person is updated on 3rd party auth provider (e.g. someone updates their profile picture for their Google Account) update theirperson.EditAPI Key details Edit API Key Record to Update the Description, Name & URL #58DeleteAPI Key DELETE an AUTH_API_KEY #59auth_plugconn.assigns: Make decoded JWT available on conn.assigns.person auth_plug#17