logout endpoint auth_plug_example App issue #15

[nelsonic]

• Implements MVP of logout functionality. ⏳ Implement Logout Endpoint/Handler in Example App #15

[codecov]

Codecov Report

Merging #16 (c380bfe) into main (109462f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           12        14    +2     
=========================================
+ Hits            12        14    +2     

Impacted Files	Coverage Δ
lib/app_web/controllers/page_controller.ex	100.00% <100.00%> (ø)
lib/app_web/router.ex	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109462f...c380bfe. Read the comment docs.

[nelsonic]

Ahh ...

Need tests ... 🙄
Added them to auth_plug dwyl/auth_plug#36 ✅
but need them here too ... ⏳

[nelsonic]

Good thing testing in Elixir/Phoenix is so easy. 😉
Less than a minute later, back up to 100% coverage. 💯

[nelsonic]

The code I've added to this PR should be "enough" to logout in both the "consumer" (auth_plug_example) and the auth App. Once AuthPlug.logout/1 is finished, this PR should "just work". 💭

[nelsonic]

@SimonLab hopefully this PR is clear.
The idea is that we can easily add the /logout endpoint to any App using auth_plug.
The handler will invoke the AuthPlug.logout/1 function implemented in dwyl/auth_plug#36
Which in turn will make an HTTP Request to auth_url/end_session see: dwyl/auth#159

Once the person has auth_plug working, the /logout functionality should be very simple to implement. 💭
Let me know if you agree. 🤞
Feedback/improvement very much welcome!

[nelsonic]

This is the interesting part. 💡
With this single invocation of AuthPlug.logout/1 all "logout" action is handled transparently.

[SimonLab]

I was wondering if the logout function could failed before rendering the loggedout.html page.
I've created an issue on auth_plug: dwyl/auth_plug#38

[nelsonic]

Excellent idea to check for errors. Thanks.

[SimonLab]

LGTM 👍