Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get IP address #156

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Get IP address #156

merged 4 commits into from
Mar 15, 2022

Conversation

SimonLab
Copy link
Member

ref: #153
Extract ip address from the x-forwarded-for header values

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #156 (b70cce9) into main (6f32a14) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines           70        74    +4     
=========================================
+ Hits            70        74    +4     
Impacted Files Coverage Δ
lib/hits_web/controllers/page_controller.ex 100.00% <ø> (ø)
lib/hits.ex 100.00% <100.00%> (ø)
lib/hits_web/controllers/hit_controller.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f32a14...b70cce9. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. Thanks! 🎉

@nelsonic nelsonic merged commit ab0cfe0 into main Mar 15, 2022
@nelsonic nelsonic deleted the x-forwarded-for-#153 branch March 15, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants