Updates version of JSDOM to latest (v11) Fixes "Click" Tests which means 100% Coverage!!! #28
Conversation
… seems to have fixed them!!!) #20
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
========================================
+ Coverage 95.34% 100% +4.65%
========================================
Files 1 1
Lines 43 43
========================================
+ Hits 41 43 +2
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
…DOM tests on client! #20
|
I know I'm a "freak" but the "95% Coverage" Was Bugging me!! @iteles please review/merge when you can. thanks! |
|
@iteles review/merge not "urgent". but would be nice to get the "Tweet" done on Monday. 😉 |
| var state = root.getElementsByClassName('count')[0].textContent; | ||
| assert.equal(state, 0, "State is 0 (Zero) after reset."); // state was successfully reset to 0! | ||
| empty(root); // clean up after tests | ||
| // console.log('STATE:', state); |
There was a problem hiding this comment.
There are a couple of commented out console.logs but I'm happy to leave them in for the time being as these might actually be useful to beginners when we publicise the tutorial #29
| assert.equal(result, 0); | ||
| }); | ||
|
|
||
| // please make this test pass if you know how! thanks! :-) |
There was a problem hiding this comment.
Worth also opening an issue on this 👍
There was a problem hiding this comment.
please feel free to open that issue. thanks. 👍
|
I love how you hearted the codecov comment here 😆 |
Fixes: