Create people migration #162

SimonLab · 2022-10-04T20:43:21Z

Create people table with person.id and name
Copy existing person_id from items and tags
Add foreign key using references in items and tags

- Create people table with peron_id and name - Copy existing person_id from items and tags - Add foreign key using references in items and tags

- Create Person schema - Update Item and Tag schema to use belong_to association

Create profile endpoint to manage the name

Add edit.html.heex form to edit the name of the loggedin person

Create a router plug to assign true/false to loggedin. This to avoid having duplicated code on the controllers

Create a router plug which redirect the person to her profile to add a name when it is not defined. This to make sure that people all have name and can be found later on when sharing items

Define update functions to update the person's name

Update test to avoid ecto foreign key error with new people table

codecov · 2022-10-05T12:06:46Z

Codecov Report

Merging #162 (bff37c1) into main (40e9ea5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        13    +2     
  Lines          195       219   +24     
=========================================
+ Hits           195       219   +24

Impacted Files	Coverage Δ
lib/app/item.ex	`100.00% <ø> (ø)`
lib/app/tag.ex	`100.00% <ø> (ø)`
lib/app_web/controllers/init_controller.ex	`100.00% <ø> (ø)`
lib/app_web/controllers/tag_controller.ex	`100.00% <ø> (ø)`
lib/app/person.ex	`100.00% <100.00%> (ø)`
lib/app_web/controllers/profile_controller.ex	`100.00% <100.00%> (ø)`
lib/app_web/router.ex	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SimonLab · 2022-10-05T13:16:35Z

This PR add a simple profile page.
I have created a new migration to create the people table and the person schema linked to this table.
To keep the existing data, I run an sql command which create new person based on the existing person_id from items and tags.

Because we are going to use the unique name of the logged in person, we are redirecting the user to the edit profile page if the name is not defined yet.

Now that we have a way to find other user based on their profile name, we'll be able to start sharing items with other people

SimonLab · 2022-10-05T13:19:50Z

lib/app_web/templates/layout/root.html.heex

@@ -16,7 +16,9 @@
      <div class="container flex flex-wrap justify-between items-center mx-auto">

        <%= if @loggedin do %>
+          <a href={Routes.profile_path(@conn, :edit, @person.id)}>


Add link to the profile picture in the nav bar to the profile edit page

SimonLab · 2022-10-05T13:20:49Z

priv/repo/migrations/20221004195054_add_person.exs

+    end
+
+    # insert new people rows by select unique person_id from items and tags
+    execute(


Create person from the existing person_id from the items and tags table

Add more tests for profile schema and controller

nelsonic · 2022-10-05T21:18:27Z

lib/app/person.ex

+  import Ecto.Changeset
+  alias App.{Item, Repo, Tag}
+  alias __MODULE__
+  # https://hexdocs.pm/phoenix/Phoenix.Param.html


I find the docs for Param pretty useless. Wish there was a standalone example. 💭

nelsonic · 2022-10-05T21:21:01Z

lib/app/person.ex

+    person
+    |> cast(attrs, [:person_id, :name])
+    |> validate_required([:person_id, :name])
+    |> unique_constraint(:name, name: :people_name_index)


Can't say I understand why the :name should be unique ... the :person_id, sure, but name ...? 🤷‍♂️

I'm thinking of using the name later on in the UI to select people to add to groups. If the name is not unique we won't be able to distinguish between users. Maybe it should be called username.

nelsonic · 2022-10-05T21:22:26Z

lib/app_web/controllers/profile_controller.ex

+    case Person.update_person(profile, person_params) do
+      {:ok, _person} ->
+        conn
+        |> put_flash(:info, "Person updated successfully.")


Guessing this "Person updated successfully." is auto-generated? 🤖
Maybe we could change it to "Your profile was updated." or something a bit more friendly? 💭

The flash messages are not displayed at the moment.
The function to display them might have been removed previously, I need to have a look at it but we can definitely update the message

nelsonic

@SimonLab looks good. 👌
Only one note on the uniqueness of person.name 💭
But fairly certain we can modify this later when needed.
my first and last name are not unique by any stretch ... 🙄

Create people migration

1e702cf

- Create people table with peron_id and name - Copy existing person_id from items and tags - Add foreign key using references in items and tags

SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 4, 2022

SimonLab self-assigned this Oct 4, 2022

SimonLab temporarily deployed to dwylauth October 4, 2022 20:43 Inactive

Update schemas

0a7278b

- Create Person schema - Update Item and Tag schema to use belong_to association

SimonLab temporarily deployed to dwylauth October 4, 2022 21:20 Inactive

Add profile endpoint

2398e5b

Create profile endpoint to manage the name

SimonLab temporarily deployed to dwylauth October 4, 2022 21:52 Inactive

Add Edit profile form

211708f

Add edit.html.heex form to edit the name of the loggedin person

SimonLab temporarily deployed to dwylauth October 4, 2022 22:17 Inactive

SimonLab temporarily deployed to dwylauth October 5, 2022 09:41 Inactive

Move loggedin assign to router plug

6797530

Create a router plug to assign true/false to loggedin. This to avoid having duplicated code on the controllers

SimonLab force-pushed the person-table-schema-#290 branch from 5f2b228 to 6797530 Compare October 5, 2022 09:42

SimonLab temporarily deployed to dwylauth October 5, 2022 09:42 Inactive

Create check_person_name plug

8cfd3a9

Create a router plug which redirect the person to her profile to add a name when it is not defined. This to make sure that people all have name and can be found later on when sharing items

SimonLab temporarily deployed to dwylauth October 5, 2022 10:09 Inactive

Define udpate controller for profile

c1e015c

Define update functions to update the person's name

SimonLab temporarily deployed to dwylauth October 5, 2022 10:26 Inactive

Update test to work with Person schema/table

cbb765b

Update test to avoid ecto foreign key error with new people table

SimonLab temporarily deployed to dwylauth October 5, 2022 12:04 Inactive

SimonLab temporarily deployed to dwylauth October 5, 2022 13:12 Inactive

SimonLab requested a review from nelsonic October 5, 2022 13:16

SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 5, 2022

SimonLab force-pushed the person-table-schema-#290 branch from a1673b8 to 2b38a81 Compare October 5, 2022 13:19

SimonLab temporarily deployed to dwylauth October 5, 2022 13:19 Inactive

SimonLab commented Oct 5, 2022

View reviewed changes

Add test for profile schema and controller

bff37c1

Add more tests for profile schema and controller

SimonLab force-pushed the person-table-schema-#290 branch from 2b38a81 to bff37c1 Compare October 5, 2022 13:21

SimonLab temporarily deployed to dwylauth October 5, 2022 13:21 Inactive

SimonLab marked this pull request as ready for review October 5, 2022 13:24

SimonLab mentioned this pull request Oct 5, 2022

EPIC: groups: how to collaborate with one or more people dwyl/auth#220

Open

17 tasks

nelsonic assigned nelsonic and unassigned SimonLab Oct 5, 2022

nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Oct 5, 2022

nelsonic reviewed Oct 5, 2022

View reviewed changes

nelsonic approved these changes Oct 5, 2022

View reviewed changes

nelsonic merged commit 7d05242 into main Oct 5, 2022

nelsonic deleted the person-table-schema-#290 branch October 5, 2022 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create people migration #162

Create people migration #162

SimonLab commented Oct 4, 2022 •

edited by nelsonic

Loading

codecov bot commented Oct 5, 2022 •

edited

Loading

SimonLab commented Oct 5, 2022 •

edited

Loading

SimonLab Oct 5, 2022

SimonLab Oct 5, 2022

nelsonic Oct 5, 2022

nelsonic Oct 5, 2022

SimonLab Oct 5, 2022

nelsonic Oct 5, 2022

SimonLab Oct 5, 2022

nelsonic left a comment

Create people migration #162

Create people migration #162

Conversation

SimonLab commented Oct 4, 2022 • edited by nelsonic Loading

codecov bot commented Oct 5, 2022 • edited Loading

Codecov Report

SimonLab commented Oct 5, 2022 • edited Loading

SimonLab Oct 5, 2022

Choose a reason for hiding this comment

SimonLab Oct 5, 2022

Choose a reason for hiding this comment

nelsonic Oct 5, 2022

Choose a reason for hiding this comment

nelsonic Oct 5, 2022

Choose a reason for hiding this comment

SimonLab Oct 5, 2022

Choose a reason for hiding this comment

nelsonic Oct 5, 2022

Choose a reason for hiding this comment

SimonLab Oct 5, 2022

Choose a reason for hiding this comment

nelsonic left a comment

Choose a reason for hiding this comment

SimonLab commented Oct 4, 2022 •

edited by nelsonic

Loading

codecov bot commented Oct 5, 2022 •

edited

Loading

SimonLab commented Oct 5, 2022 •

edited

Loading