Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Lists #165

Merged
merged 59 commits into from
Nov 1, 2023
Merged

PR: Lists #165

merged 59 commits into from
Nov 1, 2023

Conversation

@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 5, 2022
@SimonLab SimonLab self-assigned this Oct 5, 2022
@SimonLab SimonLab temporarily deployed to dwylauth October 5, 2022 20:08 Inactive
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #165 (6aae78a) into main (a0e1594) will decrease coverage by 0.31%.
Report is 60 commits behind head on main.
The diff coverage is 97.33%.

@@             Coverage Diff             @@
##              main     #165      +/-   ##
===========================================
- Coverage   100.00%   99.69%   -0.31%     
===========================================
  Files           22       26       +4     
  Lines          599      659      +60     
===========================================
+ Hits           599      657      +58     
- Misses           0        2       +2     
Files Coverage Δ
lib/app/item.ex 100.00% <100.00%> (ø)
lib/app/list.ex 100.00% <100.00%> (ø)
lib/app_web/controllers/list_controller.ex 100.00% <100.00%> (ø)
lib/app_web/controllers/tag_controller.ex 100.00% <100.00%> (ø)
lib/app_web/live/components/nav.ex 100.00% <100.00%> (ø)
lib/app_web/live/stats_live.ex 100.00% <ø> (ø)
lib/app_web/router.ex 100.00% <ø> (ø)
lib/app_web/views/list_view.ex 100.00% <100.00%> (ø)
lib/app_web/views/nav_view.ex 100.00% <100.00%> (ø)
lib/app_web/live/app_live.ex 98.75% <91.30%> (-1.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SimonLab SimonLab temporarily deployed to dwylauth October 5, 2022 21:17 Inactive
Create the lists table
Create list controller to add and edit lists
Create item controller to link items to lists
@SimonLab SimonLab temporarily deployed to dwylauth October 5, 2022 21:39 Inactive
- Add/Remove list linked to an item
- Display lists as badges on main page
@SimonLab SimonLab temporarily deployed to dwylauth October 7, 2022 10:55 Inactive
lib/app/item.ex Outdated Show resolved Hide resolved
Check if person exist before insert
@SimonLab SimonLab temporarily deployed to dwylauth October 7, 2022 19:56 Inactive
Add schemas and controllers tests
@SimonLab SimonLab temporarily deployed to dwylauth October 7, 2022 21:44 Inactive
@SimonLab SimonLab temporarily deployed to dwylauth October 8, 2022 14:33 Inactive
@SimonLab
Copy link
Member Author

SimonLab commented Oct 8, 2022

Displaying the item's lists under the tags:
image

@SimonLab SimonLab marked this pull request as ready for review October 8, 2022 14:40
- Add test for item controller managing lists
- Fix #168
@SimonLab SimonLab temporarily deployed to dwylauth October 8, 2022 14:45 Inactive
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Oct 8, 2022
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 8, 2022
@nelsonic
Copy link
Member

image image

the "all" list is not editable as discussed in: #400 (comment)

@nelsonic
Copy link
Member

nelsonic commented Nov 1, 2023

Custom Lists: :shipit:

custom-lists-showcase

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Nov 1, 2023
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 😍 Thanks @SimonLab 👌

@nelsonic nelsonic merged commit 07c41ce into main Nov 1, 2023
1 check passed
@nelsonic nelsonic deleted the items-list branch November 1, 2023 17:32
@LuchoTurtle LuchoTurtle mentioned this pull request Nov 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed in-progress An issue or pull request that is being worked on by the assigned person
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants