[CT-968] Fix snapshot validation by including subaccounts from propos…

…ed operation queue (#2142)
dydxprotocol · Sep 17, 2024 · 5ccf033 · 5ccf033
1 parent a00ddb9
commit 5ccf033
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/protocol/x/clob/keeper/process_operations.go b/protocol/x/clob/keeper/process_operations.go
@@ -95,10 +95,14 @@ func (k Keeper) ProcessProposerOperations(
 		}
 		k.SendOrderbookUpdates(ctx, allUpdates)
 
-		// send local subaccount snapshots
-		subaccountIdsToUpdate := fetchSubaccountIdsInvolvedInOpQueue(
+		subaccountIdsFromProposed := fetchSubaccountIdsInvolvedInOpQueue(
+			operations,
+		)
+
+		subaccountIdsFromLocal := fetchSubaccountIdsInvolvedInOpQueue(
 			localValidatorOperationsQueue,
 		)
+		subaccountIdsToUpdate := lib.MergeMaps(subaccountIdsFromLocal, subaccountIdsFromProposed)
 		allSubaccountUpdates := make([]satypes.StreamSubaccountUpdate, 0)
 		for subaccountId := range subaccountIdsToUpdate {
 			subaccountUpdate := k.subaccountsKeeper.GetStreamSubaccountUpdate(ctx, subaccountId, false)